Add -build-artifacts-dir for configurable out-of-source artifacts #2514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by creating a dir of the name given and then doing the same thing as it used to do: `given_dir/lib/bs` and `given_dir/lib/ocaml` etc... The bs-dependencies' artifacts are in `dir/node_modules/dep_name/lib` This does not seem to significantly increase build times, but it'd be nice to make sure it doesn't. cc @chenglou @Schmavery
|
Little addition: this supports building a project out of source when used like |
|
Friendly ping :) |
|
Ah, Jordan said he had his own solution also. @jordwalke can you paste your patch too? |
|
Any chance of this getting merged? |
ulrikstrid
added a commit
to reuniverse/rocket
that referenced
this pull request
Jul 13, 2019
The code is mostly taken from rescript-lang/pull/2514 Co-authored-by: Benjamin San Souci <benjamin.sansouci@gmail.com>"
ulrikstrid
added a commit
to reuniverse/rocket
that referenced
this pull request
Jul 15, 2019
The code is mostly taken from rescript-lang/pull/2514 Co-authored-by: Benjamin San Souci <benjamin.sansouci@gmail.com>"
|
closing very old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2418 for details.
This works by creating a dir of the name given and then doing the same
thing as it used to do:
given_dir/lib/bsandgiven_dir/lib/ocamletc...
The bs-dependencies' artifacts are in
given_dir/node_modules/dep_name/libThis does not seem to significantly increase build times, but it'd be
nice to make sure it doesn't.
cc @chenglou @Schmavery