Skip to content

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Feb 13, 2018

Addresses #2515

@TheSpyder
Copy link
Contributor

while you're there would you mind fixing the spelling error in the from_opt deprecation message? ;)
https://github.com/BuckleScript/bucklescript/blob/a543643a63cc1472f11dea953bbdd7b35e133827/jscomp/runtime/js_null.mli#L81

And looking at that code, actually, should this change be @@ocaml.deprecated the way from_opt is rather than just @@deprecated?

@glennsl
Copy link
Contributor Author

glennsl commented Feb 13, 2018

Will do. I don't think the ocaml. namespace matters, but might as well be consistent.

@glennsl glennsl force-pushed the undo-breaking-change branch from a543643 to c1063d6 Compare February 13, 2018 11:03
@bobzhang bobzhang merged commit 7689055 into master Feb 14, 2018
@bobzhang bobzhang deleted the undo-breaking-change branch February 14, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants