Skip to content

Change set terminology of elt to value #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2018
Merged

Change set terminology of elt to value #2539

merged 1 commit into from
Feb 26, 2018

Conversation

chenglou
Copy link
Member

@chenglou chenglou commented Feb 23, 2018 •
edited
Loading

Second diff of #2536, pulled out.

For set, understandably it's the "key" that's hashed and compared, but everyone I've talked to think of a set item in terms of "value" instead.

@chenglou chenglou mentioned this pull request Feb 23, 2018
Merged
chenglou added a commit to chenglou/rescript-compiler that referenced this pull request Feb 23, 2018
@chenglou
[Belt] Change map terminology from elt to key
1e7f0eb 
Follow-up of rescript-lang#2539
@chenglou chenglou mentioned this pull request Feb 23, 2018
Merged
@bobzhang bobzhang merged commit bebd66c into rescript-lang:master Feb 26, 2018
@chenglou chenglou deleted the eltelt branch February 26, 2018 19:51
chenglou added a commit to chenglou/rescript-compiler that referenced this pull request Mar 6, 2018
@chenglou
Fix remainder of rescript-lang#2539
24568df
chenglou added a commit that referenced this pull request Mar 6, 2018
@chenglou
Fix remainder of #2539 (#2577)
ce87ea9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenglou @bobzhang