Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 File Upload Component Won't Show S3 Datasources in Selection #5454

Closed
daawaan4U opened this issue Apr 16, 2022 · 3 comments
Closed

S3 File Upload Component Won't Show S3 Datasources in Selection #5454

daawaan4U opened this issue Apr 16, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@daawaan4U
Copy link

Describe the bug
When adding an S3 File Upload component, the S3 Datasource selection remains empty and will not show any of the existing S3 Datasources that have already been added

To Reproduce
Steps to reproduce the behavior:

  1. Add S3 Datasource
  2. Add S3 File Upload Component
  3. Check S3 Datasource selection of the component

Expected behavior
I should be able to select the S3 datasource that has been added for the application.

Screenshots
Screenshot (45)
Screenshot (46)
Screenshot (47)
Screenshot (48)

Desktop (please complete the following information):

  • Windows 10
  • Chrome
  • 100.0.4896.88

Additional context
On a sidenote, what kind of fields does the S3 File Upload component integrate with? It doesn't work with the attachments column type for the internal database, and I can't find any of the column types for the SQL (in my case, PostgreSQL) tables either that integrates with the component

@daawaan4U daawaan4U added the bug Something isn't working label Apr 16, 2022
@aptkingston
Copy link
Member

Hey @daawaan. The S3 upload component only works with real AWS S3 at the moment, so any datasources which use custom endpoints won't be listed. That could be a good feature request though.

In terms of integrating with other fields - it's actually best integrated just with a text field. Uploading the file is a button action, and you can use the result of the upload in further actions (e.g. a save row).

The flow might look like:

  • Validate form
  • Upload file
  • Save row (use the resulting URL from the previous action, and save that inside a text field to use later). A binding like {{ Action 2.File URL }} is available.

@aptkingston
Copy link
Member

Going to close this off since it isn't a bug, but feel free to open a feature request for allowing the S3 upload to work with S3-compatibile datasources if that's something you need.

@daawaan4U
Copy link
Author

Hey @aptkingston, thanks for the reply! I checked the first pull request for the S3 File Upload component and from what I understood, the Endpoint field has to be empty in order for the S3 Datasource to show up in the S3 File Upload component?

I think the current Form for the S3 Datasource is misleading from a UX standpoint. Instead of filtering out the datasources with the endpoint field filled in, the S3 Datasource form shouldn't let users enter a custom endpoint instead. My suggestion is to add a validation guard for the Endpoint field instead to check if it is an S3-compatible endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants