Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 File Upload component should work with other S3-compatible services, not just AWS #5587

Open
melohagan opened this issue Apr 26, 2022 Discussed in #5459 · 6 comments
Open
Labels
enhancement New feature or request needs-triage Needs more investigation, and not ready to progress until that happens. s3 Relating to AWS S3 Bucket

Comments

@melohagan
Copy link
Collaborator

melohagan commented Apr 26, 2022

Discussed in #5459

Originally posted by daawaan April 17, 2022
Hello, I've been trying to use the S3 File Upload component since the 20MB file upload limit for attachments is too small for our use case which is explained further in #5457. Unfortunately, the S3 component isn't showing any of the S3 datasources in the dropdown for the component which I've already issued in #5454. We're using digitalocean spaces in our case and I was wondering if our datasource wasn't showing up because it isn't from AWS? Its also stated here in #4030 the first pull request for the S3 File Upload component that

S3 datasources with custom endpoints are not supported. This is mainly due to the non-compliance with presigned URL domain names. Real S3 uses bucket.domain as the FQDN, and using a custom endpoint when generating a presigned URL spits out a value of something like bucket.10.0.0.1 for example, if using a local IP address. Due to this behaviour we just have to put a limitation on this functionality that it will only work with real S3 and not MinIO.

@melohagan melohagan added the enhancement New feature or request label Apr 26, 2022
@shogunpurple shogunpurple added the needs-triage Needs more investigation, and not ready to progress until that happens. label May 25, 2022
@anborg
Copy link

anborg commented Jun 5, 2022

Please move away from MinIO.

Please Note: Minio - has changed license terms. No longer opensource or free.

"Designed for developers who are building open source applications in compliance with the GNU AGPL v3 license and are able to support themselves. It is fully featured. If you distribute, host or create derivative works of the MinIO software over the network, the GNU AGPL v3 license requires that you also distribute the complete, corresponding source code of the combined work under the same GNU AGPL v3 license. This requirement applies whether or not you modified MinIO."

If you customize budibase and add a form; because bb uses minio, you have to release your org bb-custom-code public! Whether or not you modified MinIO.

@remcoboerma
Copy link

Backblaze support would be really great. It's S3 compatible.

@stale
Copy link

stale bot commented Sep 9, 2022

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Sep 9, 2022
@stale stale bot removed the stale label Nov 26, 2022
@matteoveglia
Copy link

+1 for this
I should have checked this functionality before building most of my app which is now on hold as this functionality is vital.

I found a bit of a workaround here, it seems to use the same AWS sdk that budibase uses and it works!
https://pilvio.com/en/2021/01/21/uploading-files-from-html-page-to-an-s3-bucket/

The only downsides are that - 1. There's no easy way to retrieve the filename of what was uploaded and 2. Kind of a big one... all your S3 keys are visible in plain text in source soooooo

@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Mar 25, 2023
@michael-dm
Copy link

Any updates on this ?

@melohagan melohagan added the s3 Relating to AWS S3 Bucket label Sep 12, 2023
@melohagan melohagan removed the stale label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage Needs more investigation, and not ready to progress until that happens. s3 Relating to AWS S3 Bucket
Projects
None yet
Development

No branches or pull requests

6 participants