Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table enhancements #13510

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Table enhancements #13510

merged 11 commits into from
Apr 25, 2024

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented Apr 17, 2024

Description

This is a collection of enhancements to the new table component based on user feedback.

Changes:

  • Support resizing columns on mobile
  • Support reordering columns on mobile
  • When on small resolutions, the primary display column will no longer be pinned to the left, and will scroll as normal. This frees up a lot more space to view your data.
  • Fix issue where "Add your first row popup" was showing but should not have been

Discussed in #13366.

@aptkingston aptkingston marked this pull request as draft April 17, 2024 13:53
@aptkingston aptkingston changed the title (WIP) Table enhancements Table enhancements Apr 25, 2024
@aptkingston aptkingston marked this pull request as ready for review April 25, 2024 08:54
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Huge UX improvement for mobile! 🎉

}
})
.sort((a, b) => {
// If we don't have a pinned column then primary display will be in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user experience here, especially on mobile, is flawless. 👌

@aptkingston aptkingston merged commit 8a72be5 into master Apr 25, 2024
10 checks passed
@aptkingston aptkingston deleted the grid-enhancements branch April 25, 2024 11:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants