Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing client library to be retrieved via pre-signed URL for Cloud #13557

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

mike12345567
Copy link
Collaborator

Description

Bringing back the old mechanism of returning the client library through a pre-signed URL, rather than always serving through the service.

An attempt to address some of the periods of very slow S3 performance we have been experiencing recently.

…gh a pre-signed URL, rather than always serving through the service.
@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label Apr 24, 2024
@mike12345567 mike12345567 self-assigned this Apr 24, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner April 24, 2024 14:38
@mike12345567 mike12345567 requested review from adrinr and removed request for a team April 24, 2024 14:38
Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the lint error this seems reasonable to me. We'll want to test it in QA for sure.

@mike12345567 mike12345567 merged commit 36aacd4 into master Apr 24, 2024
10 checks passed
@mike12345567 mike12345567 deleted the fix/pre-sign-client-lib branch April 24, 2024 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants