Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing improvements for REST integration - fixing no responses #13640

Merged
merged 4 commits into from
May 8, 2024

Conversation

mike12345567
Copy link
Collaborator

@mike12345567 mike12345567 commented May 8, 2024

Description

Typing improvements around the REST integration to make sure when no response is returned it doesn't break anything.

Addresses: https://linear.app/budibase/issue/BUDI-8147/issue-when-a-rest-endpoint-responds-with-status-code-204-and-no
#13412

image

…response is returned it doesn't break anything.
@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label May 8, 2024
@mike12345567 mike12345567 self-assigned this May 8, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner May 8, 2024 15:09
@mike12345567 mike12345567 requested review from adrinr and removed request for a team May 8, 2024 15:09
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike12345567 mike12345567 merged commit c99e810 into master May 8, 2024
10 checks passed
@mike12345567 mike12345567 deleted the fix/BUDI-8147 branch May 8, 2024 15:24
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants