Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing AUTOMATION_THREAD_TIMEOUT environment variable #13670

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

mike12345567
Copy link
Collaborator

Description

Changing the logic of how automation thread timeout gets applied, so that it can be used properly - there was a bit of logic around making sure the query thread timeout and automation thread timeout aligned properly (if you allow long queries, you should allow long automations) this was broken - always defaulting to the smallest, ignoring what was set for thread timeout.

Addresses

@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label May 13, 2024
@mike12345567 mike12345567 self-assigned this May 13, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner May 13, 2024 11:55
@mike12345567 mike12345567 requested review from adrinr and removed request for a team May 13, 2024 11:55
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments

packages/builder/src/stores/builder/automations.js Outdated Show resolved Hide resolved
packages/server/src/environment.ts Show resolved Hide resolved
@mike12345567 mike12345567 merged commit dd5a4bd into master May 13, 2024
10 checks passed
@mike12345567 mike12345567 deleted the fix/13660 branch May 13, 2024 13:10
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants