-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prop to change the size of the date number? On OnePlus5. The date text is being cut off. #86
Comments
Tried #64, it didn't work. When are you planning to release the Pull request? |
You can point directly to this repo to try the latest code which has the prop It looks like the text is too wide to fit in the container and is getting truncated. Please post your |
<CalendarStrip |
I am already pointing to version 1.3.1. That doesn't have the |
Pointing to a version pulls from the npm registry. Use the repo url:
|
Hi, the |
It appears that the calculated font size Another test would be to reduce the width of the CalendarStrip, either forced through its style or wrap it in a View container. That's just an experiment, not proposing it as a solution for you. If that works, a new prop may be needed to fine tune the responsive text sizing. |
@ZeerakHameem The easiest way for you to iterate on it is to edit the files under I'm not thrilled with the magic numbers used to calculate the sizes. It may need to take into account PixelRatio or some other dynamically fetched value. |
@peacechen @ZeerakHameem I have a pull request for this issue |
Thanks @asimkhan0 👍 I'll publish on npm after it's gotten more testing. For the time being you can use this by pointing the package.json directly to this repo:
|
The text cutoff issue on OnePlus devices is caused due to the OnePlus Slate font. Change the default font to Roboto and it should work. I have tested this on a OnePlus device. Also adding an extra space at the end of string literals will fix the issue. But the recommended approach is to load your font and use it throughout the App. |
Thanks @GIT-Sachin for reporting that. Would you mind creating a PR to add that information to the Readme? Create a new section towards the bottom titled Does reducing the |
@peacechen I have tested with fontSize for dateNumberStyle and it still does not work. Also I have created a pull request. I haven't mentioned the workaround of adding space at the end of string literals since it is not applicable in this case and also not recommended. |
* Update Readme with device specific notes for OnePlus font (BugiDev#188, BugiDev#86) * Add callback feature to markedDates prop. Fix selected dot style. * Fix scrollable initial month header and next selector (BugiDev#191). * Debounce onLayout to reduce resize thrashing (BugiDev#184). * 2.0.2 * Fix scrolling animation bug on iOS devices (BugiDev#193) * Add prop `onHeaderSelected` (BugiDev#182). * 2.0.3 * Add `lines` feature to markedDates (BugiDev#190). Update example app with lines and dots. * Add `headerText` prop to support custom header text (BugiDev#129). Co-authored-by: peacechen <github@ghpc.33mail.com> Co-authored-by: Caio Biodere <caiobiodere@gmail.com>
See Readme for OnePlus work-around |
How to get only the month name like you're getting in your screen? I'm getting month name with year, I don't want that? |
No description provided.
The text was updated successfully, but these errors were encountered: