Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing highlightDateContainerStyle as a prop #261

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

dezse97
Copy link
Contributor

@dezse97 dezse97 commented Jan 17, 2021

Solves #259 :)

@peacechen
Copy link
Collaborator

peacechen commented Jan 18, 2021

Thanks @dezse97 for adding this prop. I'll make some minor changes (code styling, remove version bump etc). Upon reviewing the existing props, the new one should be highlightDateContainerStyle to remain consistent

@peacechen peacechen changed the title Allow passing selectedDateContainerStyle as a prop Allow passing highlightDateContainerStyle as a prop Jan 18, 2021
@peacechen
Copy link
Collaborator

@dezse97
Please test your fork after the changes I made. There was a logic error in the changes to _dateViewStyle that prevented the animation on the selected date.

@dezse97
Copy link
Contributor Author

dezse97 commented Jan 18, 2021

Thank you for the changes and the quick review @peacechen. Yes, it's working fine after your changes as well. :) It can be merged from my side.

@peacechen peacechen merged commit 49ecc6f into BugiDev:master Jan 18, 2021
@ysmike
Copy link
Contributor

ysmike commented Jan 29, 2021

Is this prop working for v2.1.5? @peacechen @dezse97

@peacechen
Copy link
Collaborator

Published in 2.1.6
I was waiting on other changes in the works, but it sounds like you need this feature now.

@ysmike
Copy link
Contributor

ysmike commented Feb 1, 2021

Thank you! @peacechen
It looks like dayContainerStyle overrides highlightDateContainerStyle. Is this the expected behavior? I'd like to style all the days of the week with a different styling for the selected date.

@peacechen
Copy link
Collaborator

The current code does have dayContainer style overriding the others:

highlightDateContainerStyle should probably take precedence. Hopefully no one is using both. Would you mind testing it with _dateViewStyle and dayContainerStyle flipped in the day component above?

@ysmike
Copy link
Contributor

ysmike commented Feb 12, 2021

When those two props swap places, the background color of the dayContainerStyle no longer works. Certain other props passed to the dayContainerStyle does apply whether flipped or not. Any thoughts? @peacechen

@QuintonC
Copy link
Contributor

QuintonC commented Aug 17, 2021

-- deleted as issues from previous comment are handled in #318 --

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants