Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] Snippets for gen2 SDKs #3299

Merged
merged 37 commits into from
May 28, 2024
Merged

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented May 20, 2024

Description

Adds snippets for:

  • react
  • nextjs-app-dir
  • nextjs-app-dir-client
  • nextjs-pages-dir
  • angular
  • angular-ssr
  • qwik-city
  • react-native
  • solidjs
  • svelte
  • sveltekit

@sidmohanty11 sidmohanty11 requested review from samijaber and a team as code owners May 20, 2024 06:01
Copy link

changeset-bot bot commented May 20, 2024

⚠️ No Changeset found

Latest commit: 5204009

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 5:58pm
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 5:58pm
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 5:58pm
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 5:58pm

Copy link

gitguardian bot commented May 20, 2024

⚠️ GitGuardian has uncovered 22 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2708648 Triggered Generic High Entropy Secret 7eea7d7 packages/sdks/snippets/nextjs-app-dir/app/page.tsx View secret
2708648 Triggered Generic High Entropy Secret 7eea7d7 packages/sdks/snippets/nextjs-app-dir/app/[...slug]/page.tsx View secret
2708648 Triggered Generic High Entropy Secret c650259 packages/sdks/snippets/nextjs-app-dir/app/page.tsx View secret
2708648 Triggered Generic High Entropy Secret c650259 packages/sdks/snippets/react-native/App.tsx View secret
2708648 Triggered Generic High Entropy Secret c650259 packages/sdks/snippets/svelte/src/App.svelte View secret
2708648 Triggered Generic High Entropy Secret 7f50355 packages/sdks/snippets/nextjs-app-dir-client/app/page.tsx View secret
2708648 Triggered Generic High Entropy Secret 07f9871 packages/sdks/snippets/react/src/App.tsx View secret
2708648 Triggered Generic High Entropy Secret d41f33e packages/sdks/snippets/nextjs-pages-dir/src/pages/[...page].tsx View secret
2708648 Triggered Generic High Entropy Secret 362d236 packages/sdks/snippets/qwik-city/src/routes/[...index]/index.tsx View secret
2708648 Triggered Generic High Entropy Secret d41f33e packages/sdks/snippets/nextjs-pages-dir/src/pages/index.tsx View secret
2708648 Triggered Generic High Entropy Secret 87872a2 packages/sdks/snippets/angular/src/app/app.component.ts View secret
2708648 Triggered Generic High Entropy Secret 7f50355 packages/sdks/snippets/nextjs-app-dir-client/app/[...slug]/page.tsx View secret
2708648 Triggered Generic High Entropy Secret c650259 packages/sdks/snippets/nextjs-pages-dir/src/pages/index.tsx View secret
2708648 Triggered Generic High Entropy Secret bc8c6a5 packages/sdks/snippets/nextjs-app-dir-client/app/page.tsx View secret
2708648 Triggered Generic High Entropy Secret 87872a2 packages/sdks/snippets/angular-ssr/src/app/app.component.ts View secret
2708648 Triggered Generic High Entropy Secret 5397806 packages/sdks/snippets/svelte/src/App.svelte View secret
2708648 Triggered Generic High Entropy Secret b93baca packages/sdks/snippets/svelte/src/App.svelte View secret
2708648 Triggered Generic High Entropy Secret 7ac5006 packages/sdks/snippets/sveltekit/src/routes/[...catchall]/+page.server.js View secret
2708648 Triggered Generic High Entropy Secret 1802008 packages/sdks/snippets/solidjs/src/App.tsx View secret
2708648 Triggered Generic High Entropy Secret c650259 packages/sdks/snippets/nextjs-app-dir-client/app/page.tsx View secret
- Generic High Entropy Secret 7ac5006 packages/sdks/snippets/sveltekit/src/routes/[...catchall]/+page.server.js View secret
- Generic High Entropy Secret 5397806 packages/sdks/snippets/sveltekit/src/routes/[...catchall]/+page.server.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented May 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5204009. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! 🎉

@samijaber samijaber merged commit f8aa931 into BuilderIO:main May 28, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants