Move vot-bot out of web-svc pod into its own deployment #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingerf
reviewed
Jan 26, 2018
There was a problem hiding this comment.
Awesome, thanks for tackling this. Just had two minor comments below.
The issue you mentioned about not seeing request stats in the dashboard is a result of not running a version of the proxy that includes the fix from linkerd/linkerd2#210. I tried your branch with that fix, and it looks like this:
🎉 🎉 🎉
emojivoto/emojivoto.yml
Outdated
| kind: Deployment | ||
| metadata: | ||
| name: vote-bot | ||
| namespace: default |
There was a problem hiding this comment.
I think we should run this in the emojivoto namespace.
emojivoto/emojivoto.yml
Outdated
| command: ["emojivoto-vote-bot"] | ||
| env: | ||
| - name: WEB_HOST | ||
| value: "web-svc.emojivoto.svc.cluster.local:80" |
There was a problem hiding this comment.
If you move this to the emojivoto namespace, then you can use "web-svc:80" as the web host, and that will exercise more of the destination api.
dadjeibaah
force-pushed
the
deebo91/move-vot-bot
branch
from
0fe9320
to
aa3768f
Compare
klingerf
approved these changes
Jan 26, 2018
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
dadjeibaah
force-pushed
the
deebo91/move-vot-bot
branch
from
aa3768f
to
d5d7b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to gain visibility of downstream requests of vote-bot to web-svc, this PR edits the
emojivoto.ymlto effectively place the vote bot into its own pod.A look at the dashboard shows that stats are not being show for the downstream requests and this might be a possible bug?
