(feat) #15 Add support for database schema setting #16
Conversation
nfldb should be installable in a non-public schema if desired, this commit sets the search_path for the cursor so that all queries will be against the desired DB schema first and public second
nfldb should be installable in a non-public schema if desired, this commit sets the search_path for the cursor so that all queries will be against the desired DB schema first and public second Squashed commits: (feat) #2 Add support for database schema setting to config file (feat) closes #3 (feat) #1 add a _PFX_ replacement mechanism for DDL Simple string replacement on all DDL in the db module to allow for explicit resource references in DDL updates (fix) #1 correct use of new conn tuple (fix) #1 bad call of pfx fixed (fix) #1 spaces do help
|
I'm just chiming in to say that I intend to address this, but don't yet have the time necessary to devote to it. I'm hoping I'll get to it next week. Thank you! |
|
My apologies for taking so long to give this a more careful look through, but I really don't want to merge this as-is. It touches a ton of code and clutters up every single query with a magic string. I don't think I want to maintain that going forward. However, I don't want to put you out either. It seems like you might be able to fix this with a solution outside of nfldb: http://stackoverflow.com/questions/2875610/postgresql-schema-path-permanently --- Do any of those solutions work for you? If not, why? Maybe we can figure something else out. |
|
I've just completely gutted the I'd be happy to work with you to solve whatever problem you're having though. Please file a new issue! |
nfldb should be installable in a non-public schema if desired,
this commit sets the search_path for the cursor so that all queries
will be against the desired DB schema first and public second
Squashed commits:
(feat) Add support for database schema setting to config file
(feat) add a PFX replacement mechanism for DDL
Simple string replacement on all DDL in the db module to allow
for explicit resource references in DDL updates
(fix) correct use of new conn tuple
(fix) bad call of pfx fixed
(fix) spaces do help