Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum reqiured version of Rust to 1.29 #1058

Closed
wants to merge 1 commit into from

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Sep 17, 2018

This upgrades the minimum required version of Rust to 1.29 in order to fix #916 (Zombie processes cause rg --files to hang in /proc).

I have manually confirmed that the bug is fixed when compiling ripgrep with 1.29.

It's probably better to merge this just before the next release in order for the current Rust version to still be in present in the README(?).

See also:

closes #916

This upgrades the minimum required version of Rust to 1.29 in order to
fix BurntSushi#916 (Zombie processes cause `rg --files` to hang in `/proc`).

See also:
- Rust compiler bug ticket: rust-lang/rust#50619
- Rust compiler PR with the fix: rust-lang/rust#50630

closes BurntSushi#916
@BurntSushi
Copy link
Owner

It's probably better to merge this just before the next release in order for the current Rust version to still be in present in the README(?).

Ah right yeah. Basically, to keep things sensible, I'd like to make sure any 0.x.y releases build on the same version as the 0.x.0 release. So I won't bump the minimum Rust version until I know the next release is 0.11.

I will just do that as part of the normal release process, so I'm going to close this. In theory, it could be months before a 0.11 release. :) Thank you for the reminder though and staying on top of this!

@BurntSushi BurntSushi closed this Sep 17, 2018
@sharkdp
Copy link
Contributor Author

sharkdp commented Sep 17, 2018

I'd like to make sure any 0.x.y releases build on the same version as the 0.x.0 release

Ah, that makes sense.

In theory, it could be months before a 0.11 release.

ripgrep 0.10 was six days early 😄

@sharkdp sharkdp deleted the fix-916 branch September 17, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zombie processes cause rg --files to hang in /proc
2 participants