Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Vim config files as 'vim' file type #2044

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 27, 2021

.vimrc, vimrc, _vimrc, .gvimrc, gvimrc, _gvimrc are file names for Vim configurations and written in Vim script.

This PR adds them for vim file type detection.

Documents:

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, but could you please ensure your changes are formatted in a way that is consistent with the surrounding code? In particular, please wrap your code to 79 columns (inclusive).

@rhysd
Copy link
Contributor Author

rhysd commented Oct 27, 2021

My text editor automatically applies rustfmt, but let me ensure it is formatted.

@rhysd
Copy link
Contributor Author

rhysd commented Oct 27, 2021

Ah, ok, it is marked as #[rustfmt::skip]. Let me fix it.

@rhysd
Copy link
Contributor Author

rhysd commented Oct 27, 2021

@BurntSushi I fixed all lines which excludes exceed the limit at 39eabf0.

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit ba535fb into BurntSushi:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants