Always use \n
as line terminator in the summary printer
#2805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #2795.
I took a closer look at the issue, and I noticed the following:
i.e. the summary printer outputs null bytes instead of newlines when
--null-data
is used. I don't think that's intentional, and it's a noticeable behavior, so this PR changes this to always output\n
.I wasn't sure if I should use CRLF or LF on Windows, but since LF is used by default unless
--crlf
is enabled I used LF.I also made changes to the standard printer (not included here), which I can submit in another PR if you think it's worth it. I just need to know if you'd rather output LF or CRLF on Windows in the standard printer. Using LF is a simple change, while using CRLF requires changing lots of unit tests so they pass on Windows.