Skip to content

Commit

Permalink
refactor: utilize incremental search in AccessibleChildren calls (#50)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Ritchie1108 @Bush2021
Ritchie1108 authored and Bush2021 committed Apr 3, 2024
1 parent 0732499 commit b19c4ff
Showing 1 changed file with 67 additions and 80 deletions.
147 changes: 67 additions & 80 deletions src/IAccessibleUtils.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#pragma comment(lib, "oleacc.lib")

#include <wrl/client.h>
#include <queue>
#include <thread>

using NodePtr = Microsoft::WRL::ComPtr<IAccessible>;
Expand Down Expand Up @@ -92,82 +91,73 @@ long GetAccessibleState(NodePtr node) {
}

template <typename Function>
void TraversalAccessible(NodePtr node, Function f, bool rawTraversal = false,
bool useBFS = false) {
void TraversalAccessible(NodePtr node, Function f) {
if (!node)
return;

long childCount = 0;
if (S_OK != node->get_accChildCount(&childCount) || !childCount)
return;

std::vector<VARIANT> varChildren(childCount);
if (S_OK != AccessibleChildren(node.Get(), 0, childCount, varChildren.data(),
&childCount))
return;

if (useBFS) {
BFSTraversal(node, f, rawTraversal, varChildren);
} else {
DFSTraversal(node, f, rawTraversal, varChildren);
}
}

void BFSTraversal(NodePtr node, std::function<bool(NodePtr)> f,
bool rawTraversal, std::vector<VARIANT> varChildren) {
std::queue<NodePtr> queue;
for (const auto& varChild : varChildren) {
if (varChild.vt != VT_DISPATCH)
continue;

Microsoft::WRL::ComPtr<IDispatch> dispatch = varChild.pdispVal;
NodePtr child = nullptr;
if (S_OK != dispatch->QueryInterface(IID_IAccessible, (void**)&child))
continue;

queue.push(child);
}
auto nStep = childCount < 20 ? childCount : 20;
for (auto i = 0; i < childCount;) {
auto arrChildren = std::make_unique<VARIANT[]>(nStep);

while (!queue.empty()) {
NodePtr current = queue.front();
queue.pop();
long nGetCount = 0;
if (S_OK == AccessibleChildren(node.Get(), i, nStep, arrChildren.get(),
&nGetCount)) {

if (rawTraversal) {
if (f(current))
break;
bool bDone = false;
for (int j = 0; j < nGetCount; ++j) {
if (arrChildren[j].vt != VT_DISPATCH) {
continue;
}
if (bDone) {
arrChildren[j].pdispVal->Release(); // 立刻释放，避免内存泄漏
continue;
}

long childCount = 0;
if (S_OK == current->get_accChildCount(&childCount) && childCount > 0) {
std::vector<VARIANT> varChildren(childCount);
if (S_OK == AccessibleChildren(current.Get(), 0, childCount,
varChildren.data(), &childCount)) {
for (const auto& varChild : varChildren) {
if (varChild.vt != VT_DISPATCH)
continue;

Microsoft::WRL::ComPtr<IDispatch> dispatch = varChild.pdispVal;
NodePtr child = nullptr;
if (S_OK !=
dispatch->QueryInterface(IID_IAccessible, (void**)&child))
continue;

queue.push(child);
Microsoft::WRL::ComPtr<IDispatch> pDispatch = arrChildren[j].pdispVal;
NodePtr pChild = nullptr;
if (S_OK ==
pDispatch->QueryInterface(IID_IAccessible, (void**)&pChild)) {
if ((GetAccessibleState(pChild) & STATE_SYSTEM_INVISIBLE) == 0) {
if (f(pChild)) {
bDone = true;
}
}
}
}
} else {
if ((GetAccessibleState(current) & STATE_SYSTEM_INVISIBLE) ==
0) // 只遍历可见节点
{
if (f(current))
break;

if (bDone) {
return;
}
}

i += nStep;

if (i + nStep >= childCount) {
nStep = childCount - i;
}
}
}

void DFSTraversal(NodePtr node, std::function<bool(NodePtr)> f,
bool rawTraversal, std::vector<VARIANT> varChildren) {
// 原 TraversalAccessible 函数，现在被使用步进的新函数替代，只保留 Raw 遍历功能
template <typename Function>
void TraversalRawAccessible(NodePtr node, Function f,
bool rawTraversal = false) {
if (!node)
return;

long childCount = 0;
if (S_OK != node->get_accChildCount(&childCount) || !childCount)
return;

std::vector<VARIANT> varChildren(childCount);
if (S_OK != AccessibleChildren(node.Get(), 0, childCount, varChildren.data(),
&childCount))
return;

for (const auto& varChild : varChildren) {
if (varChild.vt != VT_DISPATCH)
continue;
Expand All @@ -178,7 +168,7 @@ void DFSTraversal(NodePtr node, std::function<bool(NodePtr)> f,
continue;

if (rawTraversal) {
TraversalAccessible(child, f, true);
TraversalRawAccessible(child, f, true);
if (f(child))
break;
} else {
Expand Down Expand Up @@ -482,7 +472,7 @@ bool IsOnBookmark(NodePtr top, POINT pt) {
}

bool flag = false;
TraversalAccessible(
TraversalRawAccessible(
top,
[&flag, &pt](NodePtr child) {
if (GetAccessibleRole(child) != ROLE_SYSTEM_PUSHBUTTON) {
Expand Down Expand Up @@ -526,28 +516,25 @@ bool IsOnMenuBookmark(NodePtr top, POINT pt) {
}

bool flag = false;
TraversalAccessible(
MenuBarPane,
[&flag, &pt](NodePtr child) {
if (GetAccessibleRole(child) != ROLE_SYSTEM_MENUITEM) {
return false;
}
TraversalAccessible(MenuBarPane, [&flag, &pt](NodePtr child) {
if (GetAccessibleRole(child) != ROLE_SYSTEM_MENUITEM) {
return false;
}

GetAccessibleSize(child, [&flag, &pt, &child](RECT rect) {
if (!PtInRect(&rect, pt)) {
return;
}
GetAccessibleSize(child, [&flag, &pt, &child](RECT rect) {
if (!PtInRect(&rect, pt)) {
return;
}

GetAccessibleDescription(child, [&flag](BSTR bstr) {
std::wstring_view bstr_view(bstr);
flag = bstr_view.find_first_of(L".:") != std::wstring_view::npos &&
bstr_view.substr(0, 11) != L"javascript:";
});
});
GetAccessibleDescription(child, [&flag](BSTR bstr) {
std::wstring_view bstr_view(bstr);
flag = bstr_view.find_first_of(L".:") != std::wstring_view::npos &&
bstr_view.substr(0, 11) != L"javascript:";
});
});

return flag;
},
false, true); // useBFS
return flag;
});

return flag;
}
Expand Down

0 comments on commit b19c4ff

Please sign in to comment.