Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right_click_close 启用,右键关闭tab似乎有bug #69

Closed
Echo1188 opened this issue May 6, 2024 · 5 comments
Closed

right_click_close 启用,右键关闭tab似乎有bug #69

Echo1188 opened this issue May 6, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Echo1188
Copy link

Echo1188 commented May 6, 2024

环境:
124-1 8 6
Chrome: 版本 124.0.6367.79(正式版本) (64 位)
Chrome++: 1.8.6

配置:
[tabs]
double_click_close=1
right_click_close=1
keep_last_tab=1
wheel_tab=1
wheel_tab_when_press_rbutton=0
open_url_new_tab=1
open_bookmark_new_tab=1
new_tab_disable=0
new_tab_disable_name="about:blank","新建标签"


问题描述:
1、假如我有tab 1, tab 2两个标签页,我用右键关闭 tab 2时,经常会同时关闭tab 1。(如下gif图)
issue69record

2、这种情况主要发生在只有2个tab的时候,如果tab 1左边还有很多个tab页面,很少会遇到以上情况。
3、从1.8.2升上来的,1.8.2前没遇到过。

@Bush2021 Bush2021 added the bug Something isn't working label May 6, 2024
@Itzamana
Copy link

Itzamana commented May 6, 2024

更新到稳定版124.0.6367.119试试?

Bush2021 pushed a commit that referenced this issue May 7, 2024
The `IsNeedKeep()` (with tick fault tolerance) introduced in the previous version will expose the issue in #69. Because when the user sends a right click, the program captures the middle click operation sent by itself, causing the two operations to be within the tick fault tolerance range, thus triggering the sending of the two commands in `HandleMiddleClick`. To this end, this commit introduces `dwExtraInfo` information to prevent the capture of operations sent by the program itself.
@Bush2021

This comment was marked as outdated.

@YorkWaugh

This comment was marked as outdated.

Bush2021 pushed a commit that referenced this issue May 7, 2024
* Improve tick judgment conditions (#69)

* Change the parameter passed into the function from `hwnd` to `top_container_view` to avoid repeated traversal
@Bush2021
Copy link
Owner

Bush2021 commented May 7, 2024

https://github.com/Bush2021/chrome_plus/releases/tag/1.8.7-alpha

version-alpha-30b9594.7z 直接测试这个吧

@Echo1188
Copy link
Author

Echo1188 commented May 8, 2024

https://github.com/Bush2021/chrome_plus/releases/tag/1.8.7-alpha

version-alpha-30b9594.7z 直接测试这个吧

这个测试右键关闭tab可以的,正常。

@Bush2021 Bush2021 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants