Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-215] Permanent token deprecation and client credentials support #68

Merged
merged 10 commits into from
Jan 14, 2021

Conversation

betacar
Copy link
Contributor

@betacar betacar commented Jan 12, 2021

  • Permanent tokens are no longer supported
  • Client credentials can be used

README.md Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
Copy link

@githuib githuib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, here's a T-rex! 🦖

{
name: 'getToken',
returnedValue: Promise.resolve({
access_token: 'i-shall-live-and-die-at-my-post',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting token string :D

@betacar betacar merged commit ca4d2e3 into development Jan 14, 2021
@betacar betacar deleted the rm/permanent-tokens branch January 14, 2021 08:49
betacar added a commit that referenced this pull request May 10, 2021
…68)

* Permanent token support removed

* Client credentials tests

* Throw an exception if permanent token is used

* Optional scope added to getToken method

* Code coverage increased

* Typofix

* Typofix

* Test unignored

* Use the redirection URI property to know if we have client credentials or not

* Test fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants