Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 5 missing API endpoints #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ConstantBqt
Copy link
Contributor

Create 5 new function to use missing endpoints

  • createMetaPropertyOption
  • modifyMetaPropertyOption
  • getSingleMetaPropertyOptions
  • syncAssetUsage
  • getAccount

Update Request handler to fix an issue with json requests (Sync asset usage)

- createMetaPropertyOption
- modifyMetaPropertyOption
- getSingleMetaPropertyOptions
- syncAssetUsage
- getAccount
@coveralls
Copy link

coveralls commented Jan 25, 2024

Coverage Status

coverage: 46.839% (-1.2%) from 48.083%
when pulling 39c1020 on ConstantBqt:add_new_api_endpoints
into 3b885e1 on Bynder:master.

Copy link

@dylanmartins dylanmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ConstantBqt Hey I see that the coverage decreased a bit, could you create some tests to cover these new calls?

Thanks!

@ConstantBqt
Copy link
Contributor Author

Hi @dylanmartins,
I have just added the PHP unit tests.
Thanks

@dylanmartins
Copy link

@ConstantBqt sorry for the late answer, did you push the commit with the tests?

@ConstantBqt
Copy link
Contributor Author

@ConstantBqt sorry for the late answer, did you push the commit with the tests?

My bad, I didn't push it 😅
Thanks

@ConstantBqt
Copy link
Contributor Author

@ConstantBqt sorry for the late answer, did you push the commit with the tests?

Hi @dylanmartins,
I have updated the code with the tests. Is there anything else I can do ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants