Fix treatment of symlinks in interactive mode #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in 560a76d did not work, because it checked the metadata of the file the symlink was pointing to, instead of the metadata of the symlink. Effectively, this resulted in symlinks never being detected. Also see https://doc.rust-lang.org/std/fs/struct.FileType.html#method.is_symlink. Fixes Byron#24.
This should provide more accurate results. Unfortunately, this cannot be easily fixed for the non-interactive part of the app, because it uses `jwalk` which does not expose any options to deal with symlinks.
ghost
merged commit 
|
Thanks so much! This is a big one, despite the small changes. It puzzles me how I could not find this in the documentation, it's quite obvious actually. I will cut a new release right away! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to use
symlink_metadatainstead ofmetadata. This makes sure that symlinks are not followed when recursively deleting directories or when calculating file sizes.The non-interactive mode is unaffected, because
jwalkdoes not provide options to deal with symlinks.