simplify traits and dyn-safety #23
Conversation
Fixed #21 `DynProgress` is sealed and implemented for any type that implements `Progress`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
They are roughly half as fast due to the dynamic call overhead.
…em to be dyn-safe. `Progress` is now `NestedProgress`, `RawProgress` is now `Progress`, and there is a new `Count` trait for solely counting things.
Conflicts: src/lib.rs src/traits.rs
|
@NobodyXu After doing some refactoring I am in a place where I am happy to make a release. This release includes #22 which now provides a way to opt-in to dynamic hierarchical progress, which previously wasn't an option. In this version, for some reason, the performance is greatly improved and we are looking at only ~30% less performance for typical counting, and even that won't be an issue if Thus, in theory, it should be possible to replace With that in mind I will start reviewing the codebase soon and use |
This should simplify downstream code and we just accept that we are dealing with a threaded world. This also comes with performance improvements as increments are now 250% faster.
Progressis nowNestedProgress,RawProgressis nowProgress, and there isa new
Counttrait for solely counting things.