Fixed Cao Protein and is passing db schema #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed node field to array instead of string * added UID to inventory and project materials
* db schema has them as singular instead of plural
bearmit
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
My computer is going crazy with the rendering of such large JSON (please help!). My general comments are:
- Define your materials in the project and reference them where you need (product, waste, ingredient, ...).
- An ingredient might be accepted without a quantity. If a null quantity is accepted we should accept without that field believe. (double check that before if you want to change).
- the name field is not required when referencing (ex:
{ node: ["Material"], uid: "_:<NAME>"}is sufficient)
| ], | ||
| "name": "WPI Methacrylation", | ||
| "type": "multistep", | ||
| "prerequisite_process": [ |
There was a problem hiding this comment.
because I was not sure how to.
how would I reference it instead or what the rules are for that?
There was a problem hiding this comment.
how would I reference it instead or what the rules are for that?
Yes, see my review comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cao Protein is passing all db schema validations