This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Changed comb.number.round to default to new comb.number.roundHalfUp method
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TechnotronicOz
commented
Jan 16, 2015
TechnotronicOz
commented
- @aheuermann
- @doug-martin
TechnotronicOz
force-pushed
the
master
branch
from
d5a511a
to
dd33638
Compare
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "comb", | |||
| "description": "A framework for node", | |||
| "version": "0.3.6", | |||
| "version": "0.3.7", | |||
There was a problem hiding this comment.
update to 0.4.0 since this could potentially be a breaking change for someone
TechnotronicOz
force-pushed
the
master
branch
2 times, most recently
from
a895315
to
2ea75d1
Compare
| assert.equal(comb.number.roundHalfUp(3.28515151515, 10), 3.2851515152); | ||
| assert.equal(comb.number.roundHalfUp(3.28515151514, 10), 3.2851515151); | ||
| assert.equal(comb.number.roundHalfUp(3.28515151516, 10), 3.2851515152); | ||
| assert.equal(comb.number.roundHalfUp(0.985, 2), 0.99); |
There was a problem hiding this comment.
why do you have a bunch of duplicate numbers in this test
There was a problem hiding this comment.
Initially I was testing to make sure the same value ran multiple times would produce the same result. I'll clean them up though.
TechnotronicOz
force-pushed
the
master
branch
from
2ea75d1
to
f6b9ee2
Compare
TechnotronicOz
force-pushed
the
master
branch
from
f6b9ee2
to
0b07ec8
Compare
doug-martin
added a commit
that referenced
this pull request
Jan 21, 2015
Changed `comb.number.round` to default to new `comb.number.roundHalfUp` method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.