Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers case sensitivity #195

Closed
janpansa opened this issue Sep 5, 2017 · 2 comments
Closed

headers case sensitivity #195

janpansa opened this issue Sep 5, 2017 · 2 comments

Comments

@janpansa
Copy link

janpansa commented Sep 5, 2017

I think your documentation should include that headers are handled case insensitive when specifying them as an array, however, if not specified as an array, they are handled strictly case sensitive.

This had me confused for a few hours.

Also, when specifying headers as an array, if they are not in the correct order or have columns missing, no error is given and no data is processed. An error only appears when too many headers is present, not too little. I think this should be mentioned in the docs as the only thing mentioned is "You may alternatively pass an array of header names which must match the order of each column in the CSV, otherwise the data columns will not match." , however I think it should read " otherwise the data columns will not match and NO DATA WILL BE IMPORTED".

Let me know if you agree, thx !

@janpansa janpansa changed the title headers case headers case sensitivity Sep 5, 2017
@aspiringguru
Copy link

this seems a useful addition to documentation. thanks for pointing it out.

@doug-martin
Copy link
Contributor

I added some docs around the headers with the strictColumnHandling option which addresses one part of your issue.

Im not sure I understand the case sensitivity issue, I know its been a while but if you could provide a short example demonstrating the issue I may be able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants