Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

DVO-5728 -> master | Convert WFC from existing config management to gull #25

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

tim-kretschmer-c2fo
Copy link
Contributor

@tim-kretschmer-c2fo tim-kretschmer-c2fo commented Jun 2, 2016

JIRA Link

Issuer

@tim-kretschmer-c2fo - Tim Kretschmer

Code Review + Discussion Complete

If any user has commented on this PR, but has not checked his or her box below, then the PR cannot be merged.

Team Lead

  • Team Lead Reviewed

Team

@tim-kretschmer-c2fo
Copy link
Contributor Author

This is one idea I had on supporting dynamically created environments. I tested it out with the dvo-5728 branch in the c2fo/wfc project and it works well. Interested on your thoughts on if there is a better approach to supporting Frenzy-like environments.

The work here grew out of the conversion from the current c2fo/wfc config bootstrapping to gull.

@tim-kretschmer-c2fo
Copy link
Contributor Author

@brockwood what do you think about this approach? Do you have another way to support dynamic environments in gull?

@brockwood
Copy link

So, before the gull command would run, we would have something like

GULL_TEMPLATE_VAR_ENV="myfrenzyenv"

set on the environment. Then, in the frenzy migration file, something like this would exist:
entries:

entries:
- path: /frenzy/redis/host
  value: '{{.ENV}}-redis.c2fo.com'

If so, looks good to me.

@tim-kretschmer-c2fo
Copy link
Contributor Author

Yup, that is exactly how it works.

@tim-kretschmer-c2fo
Copy link
Contributor Author

The neat thing is that you can drop those template variables anywhere, even in a path.

@brockwood
Copy link

Looks solid to me.

@tim-kretschmer-c2fo tim-kretschmer-c2fo merged commit 0b2384d into master Jun 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants