This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Do not typecast empty string to null for columns of type text #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheuermann
changed the title
aheuermann
force-pushed
the
text_empty_string_fix
branch
2 times, most recently
from
9f3a749
to
47896d6
Compare
|
All the other repo's fail on node 6 as well, so as long as 4/5 pass then it's probably okay. |
| this.primaryKey("id"); | ||
| this[underscore ? "text_type" : "texttype"]("text", {allowNull: false}); | ||
| this[underscore ? "blob_type" : "blobtype"]("blob", {allowNull: false}); | ||
| }); |
There was a problem hiding this comment.
is 'string' case covered?
There was a problem hiding this comment.
I added tests for the other types
aheuermann
force-pushed
the
text_empty_string_fix
branch
from
47896d6
to
b28a343
Compare
jonstacks
pushed a commit
to jonstacks/patio
that referenced
this pull request
Feb 24, 2019
Do not typecast empty string to null for columns of type text
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to save an empty string to a
texttype field unless you settypecastEmptyStringToNull: false(it defaults totrue). In this casestringisvarcharso I am assumingtextwas just left out. Let me know what you think.