This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Handle empty IN clause with quoteIdentifiers=true #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheuermann
requested review from
dustinsmith1024,
ikottman,
impatient and
jonstacks
aheuermann
commented
Oct 27, 2021
| // if the array is empty, we return an expression that will be false | ||
| return new BooleanExpression("EQ", 1, 0); | ||
| } else { | ||
| return this.literal({1: 1}); |
There was a problem hiding this comment.
I left this as-is, though it is likely also broken when quoteIdentifiers=true as well. Didn't want to change it though as this would be a change in behavior of the previous version.
jonstacks
approved these changes
Oct 27, 2021
impatient
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to handle cases where the option
quoteIdentifiers=trueso that it doesn't quote the 1("1" = 0).