This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Slight correction to andGroupedOr allowing it to be called on a dataset ... #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et which doesn't already have a where/having clause. In this case, it will just add the ORed conditions to a new where clause
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which doesn't already have a where/having clause. In this case, it will just add the ORed conditions to a new where clause
If you think it makes sense, I can also make this change to the orGroupedAnd method also, otherwise, this is ready to go, and will fix the issue with C2FO's api tests.