Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate CTDAS #26

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Integrate CTDAS #26

wants to merge 5 commits into from

Conversation

mjaehn
Copy link
Contributor

@mjaehn mjaehn commented Sep 5, 2023 •
edited

Closes #27

@mjaehn mjaehn mentioned this pull request Sep 5, 2023
Closed
@mjaehn mjaehn self-assigned this Sep 5, 2023
@mjaehn mjaehn added enhancement New feature or request refactoring Make the code more readable labels Sep 5, 2023
@mjaehn
Copy link
Contributor Author

mjaehn commented Sep 5, 2023

@efmkoene Can you remind me what the current status is here? What has to be done to fully integrate CTDAS? I assume that we want to have automatic testing via Jenkins for this case?

@mjaehn
Copy link
Contributor Author

mjaehn commented Sep 5, 2023

launch jenkins

@efmkoene
Copy link
Contributor

Hi, sorry for the late response. The current status is not easily integrated into Jenkins as a case -- we need a lot of input data (ERA5, CAMS CO2, VPRM, TNO-GHG, a bunch of files describing the 'lambda' regions, and a specific branch of the CTDAS repository from WUR) and an ICON-ART version that is not the same as the C2SM hosted version. Is that problematic, that there would be a case that is not Jenkins-ed?

@mjaehn
Copy link
Contributor Author

mjaehn commented Sep 18, 2023

Imo, it is perfectly fine for CTDAS not to be a Jenkins case. Having a large amount of input data would indeed slow down the test pipeline. So I would suggest designing the case in such a way that you at Empa are able to manually run/test it yourself.

@efmkoene
Copy link
Contributor

I'll probably push a 'final' version that can be used by Empa in the coming month.

@mjaehn mjaehn added the v3.1 label Nov 7, 2023
@mjaehn mjaehn changed the base branch from main to v3.1-rc November 11, 2023 10:01
@mjaehn mjaehn marked this pull request as draft January 29, 2024 14:19
Base automatically changed from v3.1-rc to main February 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efmkoene efmkoene

@mjaehn mjaehn

Labels
enhancement New feature or request refactoring Make the code more readable v3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate CTDAS
2 participants
@mjaehn @efmkoene