Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AKI testcases for root certs #48

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add AKI testcases for root certs #48

merged 1 commit into from
Oct 25, 2023

Conversation

facutuesca
Copy link
Contributor

Currently, these testcases fail due to validation succeeding when it should fail

woodruffw
woodruffw approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM behaviorally. I'll do a final pass and merge in a bit.

@woodruffw woodruffw merged commit fca4bdb into main Oct 25, 2023
6 checks passed
@woodruffw woodruffw deleted the test-aki-root branch October 25, 2023 18:56
@woodruffw woodruffw mentioned this pull request Oct 25, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facutuesca @woodruffw