Update value for checks%range

[ccarouge]

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Fixes #344. Update the namelist provided with the code for the changes to check%range and other fixes for compatibility with GNU compiler.

Type of change

Please delete options that are not relevant.

• Bug fix

Checklist

I have compiled the code and run the Tumbarumba test case with the updated namelist. The test case finished:

 Finished.    36.78621      seconds needed for year
 Finished.    36.78769      seconds needed for        70128  hours

Please add a reviewer when ready for review.

---

📚 Documentation preview 📚: https://cable--345.org.readthedocs.build/en/345/

[ccarouge]

@abhaasgoyal we forgot to update this namelist file with the changes to check the range.

[har917]

@ccarouge @abhaasgoyal This change looks okay ... BUT ...

I'm not sure about previous change - we've switched from a TRUE/FALSE LOGICAL kind for check%ranges to an integer but there's still a few instances in the code of IF(check%range)THEN

I can see that working for check%range=0,1 but not for 2 - at least with some compilers.

[har917]

In testing #335 and #346 I tested with check%ranges = 0, 1, 2. This would seem to be fine - at least for the compiler on gadi.

[ccarouge]

@har917 The main branch does not currently compile with GNU compiler anyway for other reasons (the abort() function for example accepts a string argument with Intel but not GNU...). But I agree we should change the IF statements as we don't want to go further from compatibility with GNU than we currently are. It's just going to be tricky to see all of these without being able to compile. I'll add that change and update the issue.

[abhaasgoyal]

@ccarouge For clarity, maybe we can have the check check%ranges /= NO_CHECK in the IF statement?

@har917 wanted to ask for which compilers is check%range=2 failing for? Edit: I see it is with the GNU compiler

[abhaasgoyal]

LGTM

[abhaasgoyal]

Edit: Apologies since already approved, but there was a small change which if done would be good. There are some check%ranges=.TRUE. in the documentation, which can also be changed (in pft_params_nml.md, and meteorological_forcings.md).

[abhaasgoyal]

LGTM