Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 #68

smngvlkz · 2024-08-17T10:15:44Z

Changes Made:

Updated cadCAD dependecy from v0.4.27 to v0.5.3 in project.toml to ensure compatibility with Python 3.10+
Incremented radCAD version from v0.13.0 to v0.14.0

Test results:

61 total tests
56 passed
5 skipped due to deprecated functionality
All core functionality tests passed successfully

Channelog Entry

Updated CHANNELOG.md for version [0.14.0]

I believe this update resolves the compatibility issues with Python 3.10 while maintaining the existing functionality of radCAD

…t cadCAD v0.5.3

BenSchZA · 2024-08-19T08:28:53Z

@smngvlkz Thanks for the fix! I have some suggestions I'll make in the PR review.

@imDarshanGK Please don't come here to mine GitHub activity 🙏

BenSchZA · 2024-08-19T08:40:08Z

pyproject.toml

@@ -8,10 +8,10 @@ packages = [
 ]

 [tool.poetry.dependencies]
-python = ">=3.8,<4.0"
+python = ">=3.9,<4.0"


@smngvlkz I imagine you removed 3.8 because cadCAD says it only supports >=3.9? The test for 3.8 still passes in the CI pipeline (see GitHub action at .github/workflows/python.yml), so we should be able to leave this as >=3.8.

If you'd like to support further, you can add Python 3.11 and 3.12 to the CI pipeline and see if the tests pass (if they fail, remove them again), and then set the Python version compatibility appropriately here—<4.0 was probably too open; for example, if they add 3.13 at some point, we can't assume that radCAD or its dependencies will support it.

The radCAD version should be updated in this file and radcad/__init__.yml to v0.14.0, and an entry should be added in the changelog for the new version explaining the changes.

@BenSchZA Thank you for your review. I believe I have addressed all the suggested changes, including updating the cadCAD dependency, expanding Python version compatibility, and refining the project configuration. I have also updated the CHANNELOG.md file to reflect the changes. Please let me know if this revised PR meets your requirements and if not, please let me know so I can make the necessary changes

Also to ensure we are future-proof and aligned with the dependencies requirements, it is wise to set the minimum Python version to 3.9. So I have decided not to change it back to 3.8

Thanks @smngvlkz!

Also to ensure we are future-proof and aligned with the dependencies requirements, it is wise to set the minimum Python version to 3.9. So I have decided not to change it back to 3.8

Generally best to judge support for Python versions based on your own package tests—it's not possible to go through every dependency and confirm that Python 3.8 is/isn't supported. Would prefer to maintain support for 3.8 for as long as possible.

i.e. if the CI test for 3.8 doesn't pass, then we can remove it, else let's leave as is.

BenSchZA · 2024-08-19T11:27:33Z

CHANGELOG.md

+
+- Resolved comp   atibility issues with Python 3.10
+
+### Maintenance


This should be included under "Changed" or "Added". "Maintenance" isn't a heading in the Keep a Changelog standard I don't think.

BenSchZA · 2024-08-19T11:27:53Z

CHANGELOG.md

+- Updated CI pipeline to test against Python 3.11 and 3.12
+- Refined Python version compatibilit     y range in project configuration
+
+## [0.13.             0] - 2023-10-26


Some formatting issues here and above it seems—see spaces.

Formatting issues fixed

BenSchZA · 2024-08-19T11:30:15Z

pyproject.toml

@@ -8,7 +8,7 @@ packages = [
 ]

 [tool.poetry.dependencies]
-python = ">=3.8,<3.13"
+python = ">=3.9,<3.13"


I see in this latest commit that you removed support for 3.8 again. Is there a specific reason for this? If it is not supported anymore, it should be indicated in the changelog under "Removed".

Would suggest setting version to <=3.12 instead of <3.13 to be more explicit, e.g. in case a version 3.125 is introduced (which although unlikely, is possible).

I just responded on the above comment for this

BenSchZA · 2024-08-19T11:38:00Z

@smngvlkz You can see that in the above CI pipeline, Python 3.11 fails. It's possible there is no easy fix for this and that only Python versions 3.8 to 3.10 should be supported.

smngvlkz · 2024-08-19T11:41:29Z

@smngvlkz You can see that in the above CI pipeline, Python 3.11 fails. It's possible there is no easy fix for this and that only Python versions 3.8 to 3.10 should be supported.

Yeah, but let me try to see if I can find a way to fix it. If all fails then we will leave it to versions 3.8 - 3.10

BenSchZA · 2024-08-19T11:49:32Z

.github/workflows/python.yml

    runs-on: ubuntu-latest
    strategy:
      matrix:
-        python-version: [3.8, 3.9, '3.10', '3.11', '3.12']
+        python-version: [3.9, 3.10, 3.11, 3.12]


The quotes should be included, otherwise it's interpreted at 3.1.

I have made the necessary changes. The CI pipeline should pass now

BenSchZA · 2024-08-19T12:50:00Z

@smngvlkz I believe Python 3.11 is failing because Pytest needs to be updated to v7.2.0. You can see this by looking at the CI logs and seeing that Pytest throws an error ImportError: cannot import name 'coroutine' from 'asyncio', and then checking the page for the installed version of Pytest on PyPy.org which shows that this older version does not support Python 3.11+.

Let's also add back Python 3.8 to the CI pipeline to check if it fails, before removing support for Python 3.8 as suggested.

BenSchZA · 2024-08-19T13:31:31Z

pyproject.toml

@@ -9,6 +9,7 @@ packages = [

 [tool.poetry.dependencies]
 python = ">=3.9,<3.13"
+memory_profiler = "^0.58.0"


@smngvlkz This shouldn't be a core dependency—it's only used when performing benchmarking.

BenSchZA · 2024-08-19T13:38:30Z

I see the test is still failing. @smngvlkz I'd suggest we remove support for 3.11 and 3.12 from the scope of this PR and instead make the necessary updates to indicate support for Python 3.8-3.10 as it was before. I think supporting Python 3.11+ will take some work.

BenSchZA · 2024-08-19T13:39:39Z

This PR resolves issue #67.

…t cadCAD v0.5.3

smngvlkz · 2024-08-19T14:46:37Z

@BenSchZA I have reset the branch to the starting point

…t cadCAD v0.5.3

smngvlkz · 2024-08-21T15:00:40Z

@BenSchZA Please review the output from running poetry lock:

Updating dependencies
Resolving dependencies...

The current project's supported Python range (>=3.8,<4.0) is not compatible with some of the required packages Python requirement:
  - cadcad requires Python >=3.9.0, so it will not be satisfied for Python >=3.8,<3.9.0

Because cadcad (0.5.3) requires Python >=3.9.0
 and no versions of cadcad match >0.5.3,<0.6.0, cadcad is forbidden.
So, because radcad depends on cadCAD (^0.5.3), version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties
    
    For cadcad, a possible solution would be to set the `python` property to ">=3.9.0,<4.0"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

The latest version of cadCAD no longer supports Python 3.8. To leverage the benefits of Python 3.9, I had to remove support for Python 3.8 from our project.

…nto fix/compatibility-mode

Updated cadCAD and radCAD to v0.14.0, and passed all tests with lates…

06b591d

…t cadCAD v0.5.3

smngvlkz changed the title ~~Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3~~ Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 for issue #67 Aug 17, 2024

smngvlkz changed the title ~~Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 for issue #67~~ Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 Aug 17, 2024

CADLabs deleted a comment from imDarshanGK Aug 19, 2024

BenSchZA reviewed Aug 19, 2024

View reviewed changes

Updated cadCAD and radCAD to v0.14.0, and passed all tests with lates…

73a1c68

…t cadCAD v0.5.3

smngvlkz force-pushed the fix/compatibility-mode branch from 652505f to 73a1c68 Compare August 19, 2024 14:40

Updated cadCAD and radCAD to v0.14.0, and passed all tests with lates…

f9ba338

…t cadCAD v0.5.3

BenSchZA added 9 commits August 24, 2024 11:13

Update pyproject.toml

6611350

Update documentation from Poetry to PDM

9862614

Migrate requirements from Poetry to PDM

d001819

Add Nox (Tox alternative) tests

a0c7452

Update tests to be compatible with Python 3.11+

534c988

Merge branch 'fix/compatibility-mode' of github.com:smngvlkz/radCAD i…

72f6072

…nto fix/compatibility-mode

Update GitHub action

033fbaa

Update GitHub action

1a501fa

Update GitHub action

bd4e37c

BenSchZA added 21 commits August 30, 2024 15:05

Update GitHub action

ccfaad4

Update GitHub action

47b2889

Update GitHub action

b1bf774

Update GitHub action

6fbf931

Update Nox file to fix recursion depth limit issue on Windows

2dfc858

Update Nox file to fix recursion depth limit issue on Windows

3919c72

Update pytest version

3a32235

Update pytest version

45b88f1

Remove pytest-monitor due to CI error

866f41c

Increase recursion limit

24dd7ef

Add RADCAD_BACKEND env variable to override during Windows tests

670c1d3

Add RADCAD_BACKEND env variable to override during Windows tests

2044df6

Add RADCAD_BACKEND env variable to override during Windows tests

e76d118

Resolve issue with tables and remove Windows from CI pipeline

d32e5c8

Update CHANGELOG, README, CI to include Windows for one last attempt

b101b6c

Remove tables override for Python3.8

86ccc91

Override deepcopy method when using Windows to avoid recurrsion errors

78ad004

Override radCAD backend when using Windows to avoid recurrsion errors

878b776

Override radCAD backend when using Windows to avoid recurrsion errors

738b632

Remove deepcopy method switch for Windows

2b78f2d

Pop Engine argument even if overridden by env variable

26794e2

BenSchZA merged commit 3e2d1b6 into CADLabs:master Sep 5, 2024
9 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 #68

Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 #68

smngvlkz commented Aug 17, 2024 •

edited

Loading

BenSchZA commented Aug 19, 2024

BenSchZA Aug 19, 2024

BenSchZA Aug 19, 2024

smngvlkz Aug 19, 2024

smngvlkz Aug 19, 2024

BenSchZA Aug 19, 2024

BenSchZA Aug 19, 2024

BenSchZA Aug 19, 2024

BenSchZA Aug 19, 2024

smngvlkz Aug 19, 2024

BenSchZA Aug 19, 2024

BenSchZA Aug 19, 2024

smngvlkz Aug 19, 2024

BenSchZA commented Aug 19, 2024

smngvlkz commented Aug 19, 2024 •

edited

Loading

BenSchZA Aug 19, 2024

smngvlkz Aug 19, 2024

BenSchZA commented Aug 19, 2024

BenSchZA Aug 19, 2024

BenSchZA commented Aug 19, 2024

BenSchZA commented Aug 19, 2024

smngvlkz commented Aug 19, 2024

smngvlkz commented Aug 21, 2024


		- Resolved comp atibility issues with Python 3.10

		### Maintenance

Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 #68

Updated cadCAD compatibility mode and tests to be compatible with latest cadCAD v0.5.3 #68

Conversation

smngvlkz commented Aug 17, 2024 • edited Loading

Changes Made:

Test results:

Channelog Entry

BenSchZA commented Aug 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenSchZA commented Aug 19, 2024

smngvlkz commented Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenSchZA commented Aug 19, 2024

Choose a reason for hiding this comment

BenSchZA commented Aug 19, 2024

BenSchZA commented Aug 19, 2024

smngvlkz commented Aug 19, 2024

smngvlkz commented Aug 21, 2024

smngvlkz commented Aug 17, 2024 •

edited

Loading

smngvlkz commented Aug 19, 2024 •

edited

Loading