Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update frontend responseType queryString #1619

Merged
merged 5 commits into from
Jul 18, 2024
Merged

feat: update frontend responseType queryString #1619

merged 5 commits into from
Jul 18, 2024

Conversation

TzuHanLiang
Copy link
Member

@TzuHanLiang TzuHanLiang commented Jul 18, 2024 •
edited
Loading

DEVELOP

  • 調整前端呼叫 API: listJournal 的邏輯、參數名稱回傳格式
  • 移除令人困惑的 useEffect
  • API 會出錯需要麻煩 @RexBearIU 幫忙檢查

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@TzuHanLiang TzuHanLiang added this to the v0.8.0 Alpha Release milestone Jul 18, 2024
@TzuHanLiang TzuHanLiang self-assigned this Jul 18, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 9:33am

@TzuHanLiang TzuHanLiang linked an issue Jul 18, 2024 that may be closed by this pull request
[FEATURE] - 日記帳清單 API 確認 #1608
Closed
@TzuHanLiang TzuHanLiang removed the request for review from Julian0701 July 18, 2024 07:10
Luphia
Luphia approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 548b39c into feature/journal_sort_pagination Jul 18, 2024
3 checks passed
@Luphia Luphia deleted the feature/journal_sort_pagination_frontend branch July 18, 2024 11:30
@RexBearIU RexBearIU linked an issue Jul 30, 2024 that may be closed by this pull request
[FEATURE] - Modify list journal return #1648
Closed
@RexBearIU RexBearIU removed a link to an issue Jul 30, 2024
[FEATURE] - Modify list journal return #1648
Closed
@RexBearIU RexBearIU linked an issue Jul 30, 2024 that may be closed by this pull request
[FEATURE] - Modify list journal return #1648
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@RexBearIU RexBearIU Awaiting requested review from RexBearIU

@jing12345678910 jing12345678910 Awaiting requested review from jing12345678910

Assignees

@TzuHanLiang TzuHanLiang

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha Release
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Modify list journal return [FEATURE] - 日記帳清單 API 確認
2 participants
@TzuHanLiang @Luphia