Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust the view-report-related data structure and pure report page example for balance sheet #1699

Merged
merged 12 commits into from
Jul 23, 2024
Merged

feat: adjust the view-report-related data structure and pure report page example for balance sheet #1699

merged 12 commits into from
Jul 23, 2024

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jul 23, 2024 •
edited
Loading

DEVELOP

  • based on branch feature/generate_reports
  • feat: balance sheet UI
  • feat: balance sheet API integration
  • feat: adjust the view-report-related data structure

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 3
    1. src/components/balance_sheet_report_body/balance_sheet_report_body_all.tsx
    2. src/pages/users/reports/[reportId]/balance-sheet/[pageId].tsx
    3. src/pages/users/reports/[reportId]/balance-sheet/index.tsx
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@arealclimber arealclimber self-assigned this Jul 23, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:45am

@arealclimber arealclimber changed the base branch from feature/generate_reports to develop July 23, 2024 10:50
@arealclimber arealclimber linked an issue Jul 23, 2024 that may be closed by this pull request
[FEATURE] - Assist Anna in implementing the three major tables #1694
Closed
@arealclimber arealclimber marked this pull request as ready for review July 23, 2024 11:00
@arealclimber arealclimber marked this pull request as draft July 23, 2024 11:02
@arealclimber arealclimber marked this pull request as ready for review July 23, 2024 11:23
@arealclimber arealclimber changed the title feat: pure report page example for balance sheet #1694 feat: adjust the view-report-related data structure and pure report page example for balance sheet Jul 23, 2024
Luphia
Luphia approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 4555222 into develop Jul 23, 2024
4 checks passed
@Luphia Luphia deleted the feature/generate_reports-review branch July 23, 2024 12:45
@Luphia Luphia added this to the v0.8.0 Alpha Release milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@jing12345678910 jing12345678910 Awaiting requested review from jing12345678910

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha Release
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Assist Anna in implementing the three major tables
4 participants
@arealclimber @Luphia @jing12345678910 @TinyMurky