Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/beta login page #2700

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Feature/beta login page #2700

merged 5 commits into from
Oct 1, 2024

Conversation

godmmt
Copy link
Member

@godmmt godmmt commented Oct 1, 2024 •
edited
Loading

DEVELOP

  • beta login page UI
  • show login animation
  • refactor some parts of user context

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 2
  • src/components/beta/login/login_page_body.tsx
  • src/pages/beta/login.tsx
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@godmmt godmmt self-assigned this Oct 1, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 0:03am

@godmmt godmmt linked an issue Oct 1, 2024 that may be closed by this pull request
[Beta Login] 建立登入頁面 #2661
Closed
This was linked to issues Oct 1, 2024
[Function] 登入 #2460
Closed
[Beta Login] 確認 Google 的登入方式及金鑰 #2662
Closed
[Beta Login] 使用 NextAuth.js 實現登入 #2664
Closed
[Beta Login] 重構 User Context #2665
Closed
[Beta Login] 將登入動畫拉出來發一個 PR & 討論修改目標事宜 #2682
Closed
@godmmt godmmt marked this pull request as ready for review October 1, 2024 11:05
Luphia
Luphia approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 7cffe0f into develop Oct 1, 2024
4 checks passed
@Luphia Luphia deleted the feature/beta-login-page branch October 1, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@godmmt godmmt

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@godmmt @Luphia