Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor report page mobile #913

Merged
merged 10 commits into from
May 29, 2024

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented May 29, 2024

DEVELOP

  • feat: style the content of filterOptionsModal for RWD
  • feat: take FilterOptionsModal as the 'decorator' to pass data in pending and history report
  • Refactor the user interface of mobile version of financial and analysis report application page (shrink the vertical space)
  • feat: pop successful toast when copied
  • refactor: make PDF in view-report page responsively and bigger on mobile devices

Tips

  • Use console.table for debugging
image
  console.table({
    history: {
      ...filterOptionsForHistory,
      period: JSON.stringify(filterOptionsForHistory.period),
    },
    pending: {
      ...filterOptionsForPending,
      period: JSON.stringify(filterOptionsForPending.period),
    },
  });

CHECK LIST

  • Use @ in import path
  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

  • none

@arealclimber arealclimber self-assigned this May 29, 2024
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 9:16am

Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 6789a4b into develop May 29, 2024
4 checks passed
@Luphia Luphia deleted the feature/refactor-report-page-mobile branch May 29, 2024 09:17
@Luphia Luphia added this to the v0.8.0 Alpha Release milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants