You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The #ifndef guards in our headers and template files are inconsistently named -- some still reflect old file names or locations, some never used the same convention in the first place, etc.. It would be simple to extend our style.py script to check and fix these automatically.
Here's a discussion of various possible naming conventions. My suggestion would be something like CARTA_PATH_TO_FILE_H_, which is close to what we have already. Maybe with the top-level directory included, so that we can distinguish between CARTA_SRC... and CARTA_TEST... ?
The text was updated successfully, but these errors were encountered:
I think a sensible convention would be CARTA_SRC_... for everything in src, and CARTA_TEST_... for everything in test. The BACKEND is redundant and should be removed. After that, the name should follow the path.
The
#ifndef
guards in our headers and template files are inconsistently named -- some still reflect old file names or locations, some never used the same convention in the first place, etc.. It would be simple to extend ourstyle.py
script to check and fix these automatically.Here's a discussion of various possible naming conventions. My suggestion would be something like
CARTA_PATH_TO_FILE_H_
, which is close to what we have already. Maybe with the top-level directory included, so that we can distinguish betweenCARTA_SRC...
andCARTA_TEST...
?The text was updated successfully, but these errors were encountered: