Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the time zone in spdlog messages to UTC #1168

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

markccchiang
Copy link
Contributor

Closes #1151. Changing the time zone in spdlog messages from local to UTC.

@kswang1029
Copy link
Contributor

@pford thank you for studying the timestamp format in casacore. 👍

@markccchiang
Copy link
Contributor Author

@kswang1029 Should we also apply this setting in the log file and performance log?

@kswang1029
Copy link
Contributor

kswang1029 commented Aug 3, 2022

yes everything displayed in the console and carta.log should be consistent in UTC.

@ajm-ska
Copy link
Collaborator

ajm-ska commented Aug 3, 2022

I was just about to ask about the log file. I thought I had checked out the wrong branch or that it wasn't working.

@kswang1029 kswang1029 self-requested a review August 3, 2022 06:55
@kswang1029
Copy link
Contributor

I see casacore log is missing in carta.log. It is seen on console. 🤔

@ajm-ska
Copy link
Collaborator

ajm-ska commented Aug 3, 2022

I see casacore log is missing in carta.log. It is seen on console. 🤔

@kswang1029 I notice that too. Could it be that the casacore log was never written to ~/.carta/log/carta.log when running a local version of CARTA, as I can't seem to find any casacore log entries from before?
I only see casacore log entries in the carta-controller log files in /var/log/carta/.

@confluence confluence merged commit bcbc987 into dev Aug 4, 2022
@confluence confluence deleted the mark/1151_change_log_time_zone_to_UTC branch August 4, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent timestamps in the log file
5 participants