Mark/1312 Consider the angle unit string from IRAM FITS images #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acdo2002 please validate the fix. |
|
Yes, I have confirmed the issue has been solved with this PR. Now the IRAM old data can be opened with this PR |
|
acdo2002
approved these changes
Oct 3, 2023
pford
approved these changes
Oct 3, 2023
kswang1029
approved these changes
Oct 11, 2023
confluence
approved these changes
Oct 11, 2023
confluence
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Consider the angle unit string for IRAM fits images * Modify the changelog
confluence
added a commit
that referenced
this pull request
Jan 18, 2024
* Prepared changelog for cherrypicked merges * Mark/1312 Consider the angle unit string from IRAM FITS images (#1313) * Consider the angle unit string for IRAM fits images * Modify the changelog * Fix scripting interface and symlink issues (#1317) * Fix scripting interface bad directory issues * Update CHANGELOG.md --------- Co-authored-by: Pam Harris <pharris@nrao.edu> Co-authored-by: Adrianna Pińska <adrianna.pinska@gmail.com> * Yuhsuan/1318 fix fitting mad (#1319) * calculate mad without nans * rename function; adjust doc * adjust test * update changelog * reserve array size * add log * Fix the hanging problem of region spectral profiles when a region is deleted (#1330) * Remove a mutex lock from the RegionSet method * Restore the region mutex in RegionSet and apply it around the regions map * skip running casa_data_autoupdate if checking version (#1308) * skip running casa_data_autoupdate if checking version * also skip for --help and -h and use shorter syntax * add whitespace to prevent false positives * Bumped version in app * Include casacore log messages in carta log (#1315) * Add CartaLogSink to log casacore messages in carta format * Use casacore NullLogSink for no logging --------- Co-authored-by: Pam Harris <pharris@nrao.edu> Co-authored-by: Adrianna Pińska <adrianna.pinska@gmail.com> * Squashed commit of the following: commit 347a6f5 Author: Pam Harris <pharris@nrao.edu> Date: Wed Jan 10 07:51:59 2024 -0700 Fix style for variable names commit 13cef9c Merge: 90f305e 0407938 Author: Pam Harris <pharris@nrao.edu> Date: Wed Jan 10 07:44:10 2024 -0700 Merge branch 'pam/update_carta-casacore' of github.com:CARTAvis/carta-backend into pam/update_carta-casacore commit 90f305e Author: Pam Harris <pharris@nrao.edu> Date: Wed Jan 10 07:36:38 2024 -0700 Fix style of variable names commit db26557 Merge: e0cbb18 fe83785 Author: Pam Harris <pharris@nrao.edu> Date: Wed Jan 10 07:30:21 2024 -0700 Merge branch 'dev' into pam/update_carta-casacore commit 0407938 Author: Pam Harris <pharris@nrao.edu> Date: Fri Oct 20 16:27:30 2023 -0600 Use shared_ptr for carta log sink in casacore LogSink commit 1f65902 Author: Pam Harris <pharris@nrao.edu> Date: Fri Oct 20 16:19:21 2023 -0600 Remove tabs from CMakeLists.txt commit e0cbb18 Author: Pam Harris <pharris@nrao.edu> Date: Fri Oct 13 10:45:52 2023 -0600 Add entry in changelog commit 74436f7 Merge: 46a3829 e21bc8d Author: Pam Harris <pharris@nrao.edu> Date: Fri Oct 13 10:12:23 2023 -0600 Merge branch 'dev' into pam/update_carta-casacore commit 46a3829 Author: Pam Harris <pharris@nrao.edu> Date: Fri Sep 1 17:31:34 2023 -0600 Fix passing std::vector for casacore::Vector No longer supported in casacore update. * Updated changelog title --------- Co-authored-by: Cheng-Chin Chiang <chengchin.chiang@gmail.com> Co-authored-by: pford <pford@nrao.edu> Co-authored-by: Pam Harris <pharris@nrao.edu> Co-authored-by: yuhsuan <43841102+YuHsuan-Hwang@users.noreply.github.com> Co-authored-by: Anthony Moraghan <ajm@asiaa.sinica.edu.tw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is implemented or fixed? Mention the linked issue(s), if any.
Closes cannot open old IRAM fits image #1312.
How does this PR solve the issue? Give a brief summary.
Add a parser for the angle unit string from IRAM FITS images in the
NormalizeUnitfunction.Are there any companion PRs (frontend, protobuf)?
No.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
The IRAM FITS images can be opened now.
Checklist
/ no changelog update neededcorresponding fix added/new e2e test createdprotobuf updated to the latest dev commit /no protobuf update needed