Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 11 #252

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Conversation

MadLamprey
Copy link
Contributor

Summary:

This pull request addresses some outdated packages in our application.

Fixes #237

Changes Made:

  • Upgrade to Angular 11 using `ng update`
    • See: https://update.angular.io/?l=3&v=10.2-11.0
    • All changes mentioned have been reviewed
    • Dependencies that have been updated, other than those mentioned in the list, include:
      • apollo-angular
      • @angular-devkit/build-angular

Proposed Commit Message:

Upgrade to Angular 11

Some of our packages are old and outdated. We should actively maintain 
and keep these packages up-to-date so it is easier to maintain in the 
future.

Let's upgrade to Angular 11 to keep our packages up-to-date.

@chunweii
Copy link
Contributor

There is a build error, please check and fix it @MadLamprey. Thank you

@Arif-Khalid
Copy link
Contributor

I have tested the changes and all current functionality is working as intended. LGTM!

@gycgabriel
Copy link
Collaborator

Version upgrades need to tested on multiple platforms similar to CATcher-org/CATcher#1242

Copy link
Contributor

@cheehongw cheehongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System

OS: Windows 10 22H2
Browser: Chrome
Browser Version: Version 121.0.6167.185 (Official Build) (64-bit)
Local Angular Version: 11.2.14
Node Version: 14.21.2
npm version: 6.14.17

Actions Run

npm install: success
npm run ng:serve:web

Tested Features

Switching between repositories
Filtering by labels

No bugs found

@vigneshsankariyer1234567890
Copy link
Contributor

macOS works too :)

System

OS: macOS 13.3.1 (Ventura)
Browser: Chrome arm64
Browser Version: Version 120.0.6099.199 (Official Build) (arm-64)
Local Angular Version: 11.2.14
Node Version: 14.21.2
npm version: 6.14.17

Actions Run

npm install: success
npm run ng:serve:web

Tested Features

Switching between repositories
Filtering by labels

No bugs found

@Arif-Khalid
Copy link
Contributor

Arif-Khalid commented Feb 20, 2024

System

OS: Windows 11 23H2
Browser: Opera GX
Browser Version: LVL5 (core: 106.0.4998.76)
Local Angular Version: 11.2.14
Node Version: 16.10.0
npm version: 7.5.6

Actions Run

npm install: success
npm run ng:serve:web

Tested Features

Switching between repositories
Filtering by labels

No bugs found

@Arif-Khalid
Copy link
Contributor

System

OS: Windows 11 23H2
Browser: Chrome
Browser Version: 121.0.6167.185 (Official Build) (64-bit)
Local Angular Version: 11.2.14
Node Version: 16.10.0
npm version: 7.5.6

Actions Run

npm install: success
npm run ng:serve:web

Tested Features

Switching between repositories
Filtering by labels

No bugs found

Copy link
Contributor

@cheehongw cheehongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MadLamprey MadLamprey merged commit db46027 into CATcher-org:main Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Angular version to 11.2.14
6 participants