Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direction cosine and spacing tolerance added #1365

Merged
merged 7 commits into from
Oct 29, 2020
Merged

Direction cosine and spacing tolerance added #1365

merged 7 commits into from
Oct 29, 2020

Conversation

sarthakpati
Copy link
Contributor

@sarthakpati sarthakpati commented Oct 28, 2020 •
edited
Loading

Fixes issue #1364

Proposed Changes

  • added some sanity checks for direction cosine
  • using new tolerance for nifti to dicom and masking in utilities

@sarthakpati sarthakpati changed the title 1364 Direction cosine and spacing tolerance added Oct 28, 2020
ashishsingh18
ashishsingh18 previously requested changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@ashishsingh18 ashishsingh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change requested - have a function instead of duplicated code.

src/cbica_toolkit/src/cbicaITKUtilities.h Outdated Show resolved Hide resolved
@sarthakpati sarthakpati merged commit 7bd997e into CBICA:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderGetka-cbica AlexanderGetka-cbica AlexanderGetka-cbica approved these changes

@ashishsingh18 ashishsingh18 Awaiting requested review from ashishsingh18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarthakpati @ashishsingh18 @AlexanderGetka-cbica