-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gif to markdown to display usage #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melhemr Thanks. The animation works and looks nice. It is a good demo. The length, however, could be substantially reduced by cutting the video to show only relevant actions. Here are some suggestions:
- Age trends is shown with too many categories
- The text harmonization is too crowded. Consider reducing the number of sites that are included to simplify the view.
- File selection dialogs should show de-cluttered folders. Make a folder with only data, harmonization model, and SPARE-* model. Set the working directory such that it starts in the desired folders and no browsing is necessary.
- Choose a data set with only a small number of categorical columns; e.g. Sex, Diagnosis, APOE, Study, and SITE.
- If possible, use the newest commit.
- GIF should be included in the repository (preferably as LFS file)
|
Since you want to have only a limited number of columns showing up in the drop down and fewer sites anyway, you should use a data set that is void of problematic categories and has a smaller number sites. |
I think it is the argument |
@AbdulkadirA One last question, what do you mean use newest commit? The branch is up-to-date |
If the branch you are using to create the animation is up-to-date with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melhemr Thanks. There was a category 1
in the SPARE-* plot. Could you remove that? It looks overall good, a bit long but acceptable for the initial demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
No description provided.