Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable packaging with briefcase #166

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

AbdulkadirA
Copy link
Contributor

@AbdulkadirA AbdulkadirA commented Feb 19, 2022

This PR enables packaging installers for Linux, Windows, and macOS.

  • Windows 10/11
  • macOS
  • Linux | will be addressed in the future

@AbdulkadirA
Copy link
Contributor Author

The installation package can be built as follows (tested on Windows 11)

git clone https://github.com/CBICA/NiBAx.git
cd NiBAx
git fetch origin refs/pull/166/head
git checkout -b briefcase FETCH_HEAD
python -m venv .env
source .env/bin/activate
python -m pip install -U pip briefcase
python -m pip install -U MarkupSafe==2.0.1
briefcase create
briefcase build
briefcase run # will open the application, close to continue
briefcase package

The installer will appear in the windows subfolder. For macOS and Linux, the installers will appear in the linux and macOS subfolders, respectively.

@melhemr
Copy link
Contributor

melhemr commented Feb 22, 2022

Hi @AbdulkadirA

Everything here has worked well for me, but I did get this one pop up message:
Screen Shot 2022-02-22 at 9 59 55 AM

Is this expected?

@AbdulkadirA
Copy link
Contributor Author

@melhemr Thanks. At what step did this happen? This indicates that you are lacking certain developer tools necessary to build the package. It is not unexpected. Note, the last command should read briefcase package --no-sign for macOS.

@melhemr
Copy link
Contributor

melhemr commented Feb 22, 2022

@AbdulkadirA this happened at briefcase package, and it happened again after briefcase package --no-sign. Should I just install the package?

@AbdulkadirA
Copy link
Contributor Author

@AbdulkadirA this happened at briefcase package, and it happened again after briefcase package --no-sign. Should I just install the package?

Yes. As far as I know this should be safe. To be extra safe, you could install the XCode command line tools separately.

@melhemr
Copy link
Contributor

melhemr commented Feb 22, 2022

@AbdulkadirA I have installed the command line tools, and proceeded with briefcase package --no-sign

Right now, this has come up:
Screen Shot 2022-02-22 at 11 09 06 AM

And the icon for the NiBAx app is a bumblebee. Is this correct?

@AbdulkadirA
Copy link
Contributor Author

And the icon for the NiBAx app is a bumblebee. Is this correct?

@melhemr Yes, this is expected. Can you install (move to Applications folder) and run NiBAx by double-clicking it?

@melhemr
Copy link
Contributor

melhemr commented Feb 22, 2022

@AbdulkadirA Yes, that works, and I'm also able to use mac search to find it and open it as well. Should I merge?

@AbdulkadirA AbdulkadirA marked this pull request as ready for review February 22, 2022 16:33
@AbdulkadirA
Copy link
Contributor Author

@melhemr I updated the description and marked the PR as ready for review. Thanks.

Copy link
Contributor

@melhemr melhemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@melhemr melhemr merged commit dfb5556 into CBICA:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants