Bugfix/bento mdb#6/fix prop duplication #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nanoid to Property entities in make_model_changlog.py script to prevent the below in generated changelogs: - properties being "reused" by multiple parent nodes/edges - duplicate relationships between the prop and connected value sets & parent entities Also add "parent_handle" attribute to Property entity in bento_meta objects for the same reasons - should allow Property entities to contain all the info required to ensure they are added properly to MDB w/o requiring additional entities See property uniqueness/distinctness conventions in https://cbiit.github.io/bento-meta/mdb-conventions.html
- Move functions shared by multiple changelog scripts to util/changelog.py from the individual scripts - Reset changeset id for changelog tests
Add nanoid to Edge entities in make_model_changlog.py script to prevent duplicate relationships from edges with identical handles to src/dst Nodes
Bump version in pyproject.toml from v0.2.3 to v0.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bento-mdb#6