Feature/no ref/update diff changelog script #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changes to make_diff_changelog to handle altered output from latest bento-mdf diff_models including processing bento-meta objects in output directly rather than creating new ones in script and properly handling 'term container' object attribute changes such as value sets and concepts that need to reference their 'parent' entity to be matched properly in a cypher statement - refactor make_diff_changelog diff splitting functions into an object that tracks the diff, statements, etc. internally and separate logic for different changes in diff output - add docstrings for DiffSplitter methods - DiffSplitter class now generates cypher statements directly rather than including intermediate step to 'segment' the changes - prefix _ to parent_handle of Property object to indicate it's meant for internal use - add 'run always' to make_mapping_changelog changesets so that they can be re-run when included models updated - move escape_quotes_in_attr function from make_model_changelog.py to changelog utils - for old mdf in make_diff_changelog, don't include _commit because it would cause issues with matching those entities - add .vscode/* to gitignore
- reset entity counter for property graph nodes and relationships for each cypher statement to make them easier to test - add _parent object attr to Tags - handle generating match clauses for entities that rely on other entities for their uniqueness (props, edges, tags) - add tests for diff changelog to test_014diff_changelog.py - update versioning tests to turn entity versioning off at the end of test so it doesn't affect subsequent tests involving entities - bump version from 0.2.4 to 0.2.5 - update dependency versions identified as security risks by dependabot
- update bento-mdf dependency - remove extraneous print statements from diff changelog test
nelsonwmoore
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary