Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's happening with the 2nd value in this repeated variable? #190

Open
JessicaFrank opened this issue Jun 2, 2021 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@JessicaFrank
Copy link
Contributor

Report from an author that their second defendant's information isn't getting populated on the PDF template. Here's what I'm seeing:

Enter multiple defendant information like what's in this answer file:
answer (99).zip (I zipped it b/c .anx files aren't allowed to be uploaded)

Look at the caption at the top of page one. Section at issue is pointed out here
image

Only Jane Ann Doe's information is showing up when assembled. The second defendant in my example anx is Mark Thomas Smith.
image
b9de9ddc-c0d2-4cb8-91a1-93bdc9529eb5.pdf

The variable is set to hold multiple values. I confirmed in anx that there are two values held by [Tenant full name with alias TE]. It's also set to overflow to an addendum and the addendum label is there.

No addendum is created. Seems like repeated values aren't treated as overflow, but also aren't included even if there's sufficient space (like with the name variable).

What's happening to the second value? @AnubhavDhingra

Here's the interview
Eviction Action Complaint - Justice Court (1) (1).zip

The PDF template at issue is the 3rd one called EA Complaint AOC Recommended

@JessicaFrank JessicaFrank added the bug Something isn't working label Jun 2, 2021
@AnubhavDhingra
Copy link
Collaborator

Hey @JessicaFrank

This is how it currently works:

Addendum values work only for non repeating variables and answers that are too long for their box.

RepeatVars and their answers expect one box per answer, and all those boxes must be grouped. The code does not currently handle overflowing extra answers that exceed the number of grouped boxes.

Tenant alias has multi answers but doesn't wrap and street address is not repeating and does wrap. This is the way the code is currently written to handle these two scenarios.
Screenshot 2021-06-03 at 9 41 56 PM

Screenshot 2021-06-03 at 9 42 30 PM

@JessicaFrank
Copy link
Contributor Author

Would adding overflow capabilities to repeat variables be a complete redo of how repeat variables are handled in the DAT? I'm looking for a complexity estimate before I go back and tell the author it's not possible right now or try to come up with a work around for her.
@AnubhavDhingra

@mikemitchel
Copy link
Contributor

@JessicaFrank i think it would be a full feature thing - repeat vars are essentially currently expected to be rendered like table style (aka stacked grouped boxes), and would have to think about how it would render on an addendum.

Example:
a list of 5 names, that only have one box on the main template page. should the other 4 names render one per line on the addendum? separated by commas?

Current work around maybe:
Create your own addendum pdf base layer page where you can actually lay it out, and make extra boxes that get grouped with main page initial box. Not sure if there is a restriction on only grouping boxes within a single page or if those box groupings could span pages? would need to test it I guess.

@JessicaFrank
Copy link
Contributor Author

@mikemitchel ran up a test with a custom addendum. I can't group across different pages. I'll have to think more about a work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants