Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default singularity cache directory to $WORKDIR/.singularity #33

Closed
kelly-sovacool opened this issue Apr 18, 2024 · 5 comments · Fixed by #37
Closed

set default singularity cache directory to $WORKDIR/.singularity #33

kelly-sovacool opened this issue Apr 18, 2024 · 5 comments · Fixed by #37
Assignees
Labels
ASPEN RepoName bug Something isn't working ccbrpipeliner/7
Milestone

Comments

@kelly-sovacool
Copy link
Member

similar to RENEE's behavior.
Otherwise, users will run out of space if their SINGULARITY_CACHEDIR env var is set to the default in ~/.singularity

@kelly-sovacool kelly-sovacool changed the title set singularity cache dir to $WORKDIR/.singularity set singularity cache dir to $WORKDIR/.singularity Apr 18, 2024
@kopardev kopardev added the ASPEN RepoName label Apr 18, 2024
@kelly-sovacool kelly-sovacool changed the title set singularity cache dir to $WORKDIR/.singularity set default singularity cache directory to $WORKDIR/.singularity Apr 18, 2024
@kelly-sovacool kelly-sovacool added the bug Something isn't working label Apr 18, 2024
@kopardev kopardev self-assigned this Apr 23, 2024
@kopardev
Copy link
Member

Fixed on the feat_singularity_cache_fix branch. Alexei testing it out.

@kopardev
Copy link
Member

kopardev commented May 9, 2024

did not fix the issue according to Alexei... I am not sure whye.. asking Kelly to test.

@kelly-sovacool can you run these

module load ccbrpipeliner
/gpfs/gsfs10/users/CCBR_Pipeliner/Pipelines/ASPEN/feat_singularity_cache_fix/bin/aspen --help
/gpfs/gsfs10/users/CCBR_Pipeliner/Pipelines/ASPEN/feat_singularity_cache_fix/bin/aspen -m=init -w=/data/CCBR/some/path
/gpfs/gsfs10/users/CCBR_Pipeliner/Pipelines/ASPEN/feat_singularity_cache_fix/bin/aspen -m=dryrun -w=/data/CCBR/some/path
/gpfs/gsfs10/users/CCBR_Pipeliner/Pipelines/ASPEN/feat_singularity_cache_fix/bin/aspen -m=run -w=/data/CCBR/some/path

This should pull the dockers in /data/${USER}/.singularity folder and not /home/${USER}/.singularity folder ... Can you confirm this expected behavior?

@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented May 9, 2024

/gpfs/gsfs10/users/CCBR_Pipeliner/Pipelines/ASPEN/feat_singularity_cache_fix/bin/aspen -m=run -
w=/data/$USER/aspen_test_iss-33

The message says it is setting the path correctly:

aspen
Working Dir       : /gpfs/gsfs12/users/sovacoolkl/aspen_test_iss-33
Samples Manifest  : /gpfs/gsfs10/users/CCBR_Pipeliner/Pipelines/ASPEN/feat_singularity_cache_fix/config/sam
ples.tsv
Singularity cache dir is NOT provided and NOT set!
Setting it to "/data/sovacoolkl/.singularity"
python is /usr/local/bin/python

However, it did not change my default singularity cache dir in the shell (which I have set in my bashrc):

echo $SINGULARITY_CACHEDIR
/data/CCBR_Pipeliner/SIFS

I also noticed there isn't a statement to export the cache dir in the bash submission script submit_script.sbatch.
Would it be better to set the cache dir in the bash submission script rather than modifying this variable in the user's shell, in case this would have unintended consequences for other tools?

@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented May 9, 2024

Trying to implement this sort of complex feature makes me want to rewrite the CLI in Python so we can begin writing unit tests, like we have for RENEE.

@kopardev kopardev added this to the 2023-06 milestone Jun 22, 2024
@kelly-sovacool
Copy link
Member Author

need to modify these lines

ASPEN/aspen

Lines 768 to 772 in f17382b

if [[ ! -z "$SING_CACHE_DIR" ]];then
EXPORT_SING_CACHE_DIR_CMD="export SINGULARITY_CACHEDIR=\"${SING_CACHE_DIR}\""
else
EXPORT_SING_CACHE_DIR_CMD=""
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASPEN RepoName bug Something isn't working ccbrpipeliner/7
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants