Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run pre-commit on all files #100

Merged
merged 5 commits into from
Jan 24, 2024
Merged

style: run pre-commit on all files #100

merged 5 commits into from
Jan 24, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Jan 19, 2024

Changes

Let's bite the bullet and run pre-commit on all files. This way, when we make edits in one function, pre-commit won't make changes in an unrelated part of the same file. It looks like these changes shouldn't affect behavior of the code, but we should test it anyway and check the docs for formatting problems.

pre-commit run --all

Tests

  • biowulf

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kopardev kopardev added the RENEE RepoName label Jan 19, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review January 23, 2024 21:29
Copy link
Contributor

@slsevilla slsevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes - delimiter was everywhere. Doing this is one go was def the safest way to get this clean.

@slsevilla slsevilla merged commit 36b698f into main Jan 24, 2024
1 check passed
@slsevilla slsevilla deleted the precommit-all branch January 24, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RENEE RepoName
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix spelling errors
3 participants